Dead code cleanups

tests/test_game.py

@@ -345,7 +345,6 @@ def test_captaincy_and_hand_sizes(session):
 
     # No captain until the crew controls a ship
     assert game.captain_player_id is None
-    assert not crud.is_player_captain(p2, game)
 
     # Highest pirat (p2) -> 4 cards, lowest (p3) -> 2 cards
     assert crud.calculate_max_hand_size(p2, game.players, game.captain_player_id) == 4
@@ -367,7 +366,6 @@ def test_captaincy_and_hand_sizes(session):
     crud.set_captain(session, game, p2.id)
     session.refresh(game)
     assert game.captain_player_id == p2.id
-    assert crud.is_player_captain(p2, game)
     # Captain privilege: +1 hand size
     assert crud.calculate_max_hand_size(p2, game.players, game.captain_player_id) == 5
 
@@ -633,6 +631,41 @@ def test_player_death_toggle(session):
     assert not player.is_dead
     assert not player.completed_personal_3
 
+def test_story_bonus_rank_grant(session):
+    game, deep, (granter, mate) = make_scene_game(session, num_pirats=2)
+    crud.toggle_objective(session, game.id, granter.id, "personal_3", True)
+    session.refresh(granter)
+    assert granter.needs_rank_3_bonus
+    start_rank = mate.rank
+    ok, _ = crud.grant_story_bonus_rank(session, game, granter, mate)
+    assert ok
+    session.refresh(granter)
+    session.refresh(mate)
+    assert not granter.needs_rank_3_bonus
+    assert mate.rank == start_rank + 1
+
+def test_story_bonus_rank_guards_and_forfeit(session):
+    game, deep, (granter, mate) = make_scene_game(session, num_pirats=2)
+    # No bonus pending yet -> refused.
+    ok, _ = crud.grant_story_bonus_rank(session, game, granter, mate)
+    assert not ok
+    crud.toggle_objective(session, game.id, granter.id, "personal_3", True)
+    session.refresh(granter)
+    mate_rank = mate.rank
+    # Can't grant to yourself, nor to the Deep -> refused, prompt stays up.
+    for bad_target in (granter, deep):
+        ok, _ = crud.grant_story_bonus_rank(session, game, granter, bad_target)
+        assert not ok
+        session.refresh(granter)
+        assert granter.needs_rank_3_bonus
+    # Forfeit (no eligible crewmate) clears the prompt without changing any Rank.
+    ok, _ = crud.grant_story_bonus_rank(session, game, granter, None)
+    assert ok
+    session.refresh(granter)
+    session.refresh(mate)
+    assert not granter.needs_rank_3_bonus
+    assert mate.rank == mate_rank
+
 def test_become_ghost_flow(session):
     game = crud.create_game(session)
     player = crud.add_player(session, game.id, "DeadRat")